Get block works with ledgerHash or ledgerVersion

Vimiso · Nov 20, 2019 · 887b603 · 887b603
1 parent 741efbe
commit 887b603
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/bitcore-node/src/modules/ripple/api/csp.ts b/packages/bitcore-node/src/modules/ripple/api/csp.ts
@@ -78,7 +78,9 @@ export class RippleStateProvider extends InternalStateProvider implements CSP.IC
 
   async getBlock(params: CSP.GetBlockParams) {
     const client = await this.getClient(params.network);
-    const ledger = await client.getLedger({ includeTransactions: true, ledgerHash: params.blockId });
+    const isHash = params.blockId && params.blockId.length == 64;
+    const query = isHash ? { ledgerHash: params.blockId } : { ledgerVersion: Number(params.blockId) };
+    const ledger = await client.getLedger({ includeTransactions: true, ...query });
     return this.transformLedger(ledger, params.network);
   }
 

diff --git a/packages/bitcore-node/src/types/namespaces/ChainStateProvider.ts b/packages/bitcore-node/src/types/namespaces/ChainStateProvider.ts
@@ -139,7 +139,7 @@ export declare namespace CSP {
     getBalanceForAddress(
       params: GetBalanceForAddressParams
     ): Promise<{ confirmed: number; unconfirmed: number; balance: number }>;
-    getBlock(params: GetBlockParams): Promise<any>;
+    getBlock(params: GetBlockParams): Promise<IBlock>;
     getBlockBeforeTime(params: GetBlockBeforeTimeParams): Promise<IBlock>;
     streamBlocks(params: StreamBlocksParams): any;
     getFee(params: GetEstimateSmartFeeParams): any;