Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP][17.0] to_backend_theme: change background #536

Open
wants to merge 2 commits into
base: 17.0
Choose a base branch
from
Open

[IMP][17.0] to_backend_theme: change background #536

wants to merge 2 commits into from

Conversation

duyquyen96
Copy link
Contributor

@duyquyen96 duyquyen96 commented Aug 13, 2024 •
edited
Loading

Ticket: [2024] Thay thế bộ icon ứng dụng Viindoo 17.0

Screenshot 2024-08-14 at 10 48 50 AM
Screenshot 2024-08-14 at 10 49 00 AM
Screenshot 2024-08-14 at 10 50 37 AM

Video

Screen.Recording.2024-08-15.at.1.21.58.PM.mov

@duyquyen96 duyquyen96 force-pushed the v17_imp_to_backend_theme branch 2 times, most recently from ea91fd1 to d61b9bc Compare August 14, 2024 03:16
@duyquyen96 duyquyen96 changed the title [WIP][IMP][17.0] to_backend_theme: change background image WIP[IMP][17.0] to_backend_theme: change background image Aug 14, 2024
@viinbot viinbot added the 🚀 Queue PR/Commit is added in build queue label Aug 14, 2024
@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Aug 14, 2024
@viinbot
Copy link
Contributor

viinbot commented Aug 14, 2024

@duyquyen96 Viindoo Test Suite has passed!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Aug 15, 2024
@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script and removed 🚀 Queue PR/Commit is added in build queue labels Aug 15, 2024
@duyquyen96 duyquyen96 force-pushed the v17_imp_to_backend_theme branch 2 times, most recently from 1208b8a to a1059c7 Compare August 15, 2024 01:32
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Building PR/Commit is start building all step in script 🚀 Queue PR/Commit is added in build queue labels Aug 15, 2024
@viinbot
Copy link
Contributor

viinbot commented Aug 15, 2024

@duyquyen96 Viindoo Test Suite has passed!

duyquyen96
duyquyen96 commented Aug 15, 2024
View reviewed changes
to_backend_theme/static/src/components/apps_menu/apps_menu_service.js
Comment on lines +9 to +17
patch(AppsMenuAction.prototype, {
setup() {
super.setup();
onMounted(() => {
this.theme = session.apps_menu.theme || "viindoo";
document.body.setAttribute('data-theme', this.theme);
})
},
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Đưa biến theme ra ngoài AppMenu để bg có thể tùy chỉnh theo lựa chọn.
Trước đó biến này nằm trong component con của AppMenu nên css của AppMenu không thể sử dụng

@duyquyen96 duyquyen96 changed the title WIP[IMP][17.0] to_backend_theme: change background image [IMP][17.0] to_backend_theme: change background image Aug 15, 2024
@viinbot viinbot removed the 🚀 Running PR/Commit is done for everything and ready for manually test label Aug 21, 2024
@viinbot viinbot added the ⚠️ Failed PR/Commit is failed when run script label Sep 5, 2024
@viinbot
Copy link
Contributor

viinbot commented Sep 5, 2024

@duyquyen96 Viindoo Test Suite has failed!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Sep 5, 2024
@viinbot
Copy link
Contributor

viinbot commented Sep 5, 2024

@duyquyen96 Viindoo Test Suite has passed!

@duyquyen96
Copy link
Contributor Author

@viinbot rebuild

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Sep 6, 2024
@viinbot
Copy link
Contributor

viinbot commented Sep 6, 2024

@duyquyen96 PR in the queue to wait for rebuild!

@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Sep 6, 2024
@viinbot
Copy link
Contributor

viinbot commented Sep 6, 2024

@duyquyen96 Viindoo Test Suite has passed!

@duyquyen96
Copy link
Contributor Author

@viinbot rebase

@viinbot
Copy link
Contributor

viinbot commented Sep 9, 2024

@duyquyen96 PR rebased!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Running PR/Commit is done for everything and ready for manually test 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Sep 9, 2024
@viinbot
Copy link
Contributor

viinbot commented Sep 9, 2024

@duyquyen96 Viindoo Test Suite has passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royle-vietnam royle-vietnam Awaiting requested review from royle-vietnam

Assignees
No one assigned
Labels
🚀 Running PR/Commit is done for everything and ready for manually test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duyquyen96 @viinbot