Add optional compatibility module for capture/form/turbo compatibility fixes #1650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an optional module, `CaptureCompatibility` which is meant to monkey patche `ActionView::Base` so that forms, turbo frames, and content_for, and other common Rails code works as-expected.
Closed
camertron
approved these changes
Feb 1, 2023
joelhawksley
reviewed
Feb 2, 2023
Co-authored-by: Joel Hawksley <[email protected]>
|
Alright, got the matrix build working and validated it's running the compatibility tests because the |
camertron
approved these changes
Feb 2, 2023
This was referenced Feb 2, 2023
|
@BlakeWilliams I updated the description to mention all issues (I could find) that would be solved by this PR. |
|
@Spone great idea, thanks for updating it! |
joelhawksley
approved these changes
Feb 2, 2023
It's not easy to add a test for this since HAML raises in this scenario too.
rmacklin
reviewed
Feb 3, 2023
Co-authored-by: Richard Macklin <[email protected]>
|
Alright, I tested this module on GitHub locally, clicked around and it all worked as expected. I also ran the tests with the patch enabled and all is 🟢. That being said, this is still experimental so please validate that it works as expected in your own applications and report any bugs you run into (with reproducible examples, please). |
tmaier
added a commit
to tmaier/view_component
that referenced
this pull request
Mar 7, 2023
joelhawksley
added a commit
that referenced
this pull request
Mar 8, 2023
…1674) * Add capture_compatibility_patch_enabled as option Related to #1650 and #1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Joel Hawksley <[email protected]>
This was referenced Mar 23, 2023
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…y fixes (ViewComponent#1650) This adds an optional module, `CaptureCompatibility` which is meant to monkey patch `ActionView::Base` so that forms, turbo frames, and content_for, and other common Rails code works as-expected.
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Dec 22, 2023
…iewComponent#1674) * Add capture_compatibility_patch_enabled as option Related to ViewComponent#1650 and ViewComponent#1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Joel Hawksley <[email protected]>
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…y fixes (ViewComponent#1650) This adds an optional module, `CaptureCompatibility` which is meant to monkey patch `ActionView::Base` so that forms, turbo frames, and content_for, and other common Rails code works as-expected.
claudiob
pushed a commit
to claudiob/view_component
that referenced
this pull request
Jan 3, 2024
…iewComponent#1674) * Add capture_compatibility_patch_enabled as option Related to ViewComponent#1650 and ViewComponent#1644 * Update CHANGELOG.md * Update docs/known_issues.md * Update docs/known_issues.md * reorder item * make test more flexible to account for change in rails main --------- Co-authored-by: Joel Hawksley <[email protected]> Co-authored-by: Joel Hawksley <[email protected]>
|
Thank you for this!! Just blundered into this particular bug and was super stoked to find all I had to do was update the gem and enable the experimental mode 🎉 |
|
Thank you for this, everyone who was involved. You all rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional module,
CaptureCompatibilitywhich is meant tomonkey patch
ActionView::Baseso that forms, turbo frames, andcontent_for, and other common Rails code works as-expected.
Close #1651, close #1384, close #1485, close #1099, close #241, close #1607, close #1137