Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for the default: option for a global translation #1263

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

elia
Copy link
Contributor

@elia elia commented Feb 9, 2022

Summary

Previously the default value would have taken precedence over the
global translation fallback.

@elia elia self-assigned this Feb 9, 2022
@elia elia force-pushed the elia/translatable-defualt-value-fix branch 4 times, most recently from 33b29ee to d5524e5 Compare February 10, 2022 19:30
Previously the default value would have taken precedence over the
global translation fallback.
@elia elia force-pushed the elia/translatable-defualt-value-fix branch from d5524e5 to 0792473 Compare February 10, 2022 19:39
@elia elia marked this pull request as ready for review February 10, 2022 19:45
@elia elia requested a review from a team as a code owner February 10, 2022 19:45
@joelhawksley joelhawksley merged commit 5796df9 into main Feb 10, 2022
@joelhawksley joelhawksley deleted the elia/translatable-defualt-value-fix branch February 10, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants