-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated dates taking precendence over published even when setting is turned off #1749
Comments
I acknowledge the problem. I am undecided on what to do: is the distinction important enough to justify an increase of database size? |
I think one additional date value can't hurt any proper database |
I think it makes sense to have both fields. |
Some creators go back and keep changing their content. It is debatable if this should result in bumping the content to the front again, but for exactly this reason if the RSS feed provides the distinction, the app should too... |
It's not just an additional field in the database, I am also thinking about how this should affect the user interface. In fact, since 2006 😱 (commit ad60f21 for version 2.1.0), the Let's take an analogy : since OS X, Apple's filesystem handles multiple dates for files : creation date, date added, last modification date, last access date… In my opinion, Vienna's philosophy is similar to Apple's one : hide complexity as much as possible.
|
I am concerned that users might not understand what "created date" means in this context (maybe "date added" or "date fetched" instead?) and that they cannot see that date anywhere. What would be the harm of adding another column that is not visible by default? Maybe Vienna should be clearer about which date it shows, e.g. by changing the label from simply "date" to "date published/modified"? |
Only when there is a provided publication date on creation, use that one without questioning it Fix publication date not being transmitted by RefreshManager.m Most dates interpretations/manipulations are now in Database.m During fetching from feeds, we just retrieve the infos and store them in relevant Article fields. This makes the logic more apprehensible and easier to maintain. Solves issue ViennaRSS#1749 Co-authored-by: Barijaona Ramaholimihaso <[email protected]>
Only when there is a provided publication date on creation, use that one without questioning it Fix publication date not being transmitted by RefreshManager.m Most dates interpretations/manipulations are now in Database.m During fetching from feeds, we just retrieve the infos and store them in relevant Article fields. This makes the logic more apprehensible and easier to maintain. Solves issue ViennaRSS#1749 Co-authored-by: Barijaona Ramaholimihaso <[email protected]>
Describe the bug
updated
dates taking precendence overpublished
even when setting is turned offTo Reproduce
Mark updated articles as new
setting turned off, set order by date descdencingScreenshots
xml to test: https://www.youtube.com/feeds/videos.xml?playlist_id=UULF21uZkfXpT8rPY-gPgMiCwA
Please complete the following information:
Additional information:
In which version of Vienna does the problem not occur, if applicable.
The text was updated successfully, but these errors were encountered: