Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmuser: find correct service port of operator's CRD #961

Merged
merged 2 commits into from
May 23, 2024
Merged

vmuser: find correct service port of operator's CRD #961

merged 2 commits into from
May 23, 2024

Conversation

Looka149
Copy link
Contributor

fix: #960

@Looka149 Looka149 requested review from Amper and Haleygo as code owners May 22, 2024 22:58
Haleygo
Haleygo previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Could you also help adding this fix to changelog

vmauth: fix url when default http port is changed in targetRef. See this issue for details.

@Looka149
Copy link
Contributor Author

@Haleygo

LGTM! Could you also help adding this fix to changelog

vmauth: fix url when default http port is changed in targetRef. See this issue for details.

Added. Thanks.

Haleygo
Haleygo approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

@Haleygo Haleygo merged commit 4b059a4 into VictoriaMetrics:master May 23, 2024
2 checks passed
@Looka149 Looka149 deleted the fix/vmuser-consider-useAsDefault branch May 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haleygo Haleygo Haleygo approved these changes

@Amper Amper Awaiting requested review from Amper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Looka149 @Haleygo