Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vmselect cache dir mount when enableStrictSecurity #732

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Aug 25, 2023

After enable strict securityContext in v0.36.0 by default, if vmselect.cacheMountPath not set, vmselect won't be start successfully cause default cache dir "/tmp" is protected.
Fix this by using /cache dir and mount to emptyDir if vmselect.cacheMountPath not set.

Another fix is for vmselect and vmstorage, both podSecurityContext was set to non-nil, thus default podSecurityContext won't be applied to them.

@Haleygo Haleygo requested review from Amper and f41gh7 August 25, 2023 09:34
Copy link
Contributor

@Amper Amper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amper Amper merged commit e00fe21 into master Aug 25, 2023
3 checks passed
@Amper Amper deleted the fix-vmselect-cache-dir-when-enable-rootreadonly branch August 25, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants