Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/finalize: fixes typo at PDB delete function #1039

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

f41gh7
Copy link
Collaborator

@f41gh7 f41gh7 commented Jul 17, 2024

Previously name and namespace args were misplaced at removeFinalize function call. It prevented from proper object deletion. And caused various errors during objects deletion.

#1036

Previously name and namespace args were misplaced at removeFinalize function call.
It prevented from proper object deletion. And caused various errors during objects deletion.

#1036
Signed-off-by: f41gh7 <[email protected]>
Copy link
Contributor

@Haleygo Haleygo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haleygo Haleygo merged commit d3a0fa8 into master Jul 18, 2024
2 checks passed
@Haleygo Haleygo deleted the gh-1036 branch July 18, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants