-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle non zero deletionTimestamp for child objects. #953
Labels
bug
Something isn't working
Comments
Here's the reproducer if needed:
|
f41gh7
added a commit
that referenced
this issue
May 20, 2024
… DeletionTimestamp Kubernetes performs soft delete and waits for object hard delete until finalizers == 0. During that period any actions for soft deleted objects aren't performend. It caues weird behavior for service accounts, deployments and etc. When kubernetes-controller manager ignores actions that must be performend with it. For instance, pod creation for soft deleted deployment. Operator now detects soft delete and free objects. An object ll be recreate at the next reconcile loop and error message ll be logged. #953
f41gh7
added a commit
that referenced
this issue
May 21, 2024
f41gh7
added a commit
that referenced
this issue
May 21, 2024
… DeletionTimestamp (#956) * controllers/finalize: Remove finalizer for child objects for non zero DeletionTimestamp Kubernetes performs soft delete and waits for object hard delete until finalizers == 0. During that period any actions for soft deleted objects aren't performend. It caues weird behavior for service accounts, deployments and etc. When kubernetes-controller manager ignores actions that must be performend with it. For instance, pod creation for soft deleted deployment. Operator now detects soft delete and free objects. An object ll be recreate at the next reconcile loop and error message ll be logged. #953 * apply review comments
Changes was included to v0.45.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, if by mistake ServiceAccount ( or any other object) was deleted, operator doesn't remove finalizer for it. Since parent object wasn't marked as deleted. It blocks kubernetes control-plain operations.
Proposed solution:
The text was updated successfully, but these errors were encountered: