Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMAuth skip broken VMUsers during config building #1047

Closed
f41gh7 opened this issue Jul 25, 2024 · 1 comment
Closed

VMAuth skip broken VMUsers during config building #1047

f41gh7 opened this issue Jul 25, 2024 · 1 comment
Assignees
@f41gh7
Labels
bug Something isn't working

Comments

@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 25, 2024

Currently, a single VMUser with incorrect configuration could break VMAuth config generation.

It must be changed in the same way, as currently handled scrape objects.

It needed because VMUser object could be created by non-owner of VMAuth.

It'd be great in addition:

  • add validation to the webhook configuration (related to the required url related fields)
  • add status to the VMUser object
  • print summary into operator log
@f41gh7 f41gh7 added the bug Something isn't working label Jul 25, 2024
@f41gh7 f41gh7 self-assigned this Jul 25, 2024
f41gh7 added a commit that referenced this issue Jul 29, 2024
@f41gh7
api/vmuser: adds status.lastSyncError
45c9331 
Changes behaviour of VMAuth config generation:
* now it skips misconfigured VMUser objects and continues config generation without it
* misconfigured VMUsers marked with error at lastSyncError field
* configuration checks better for misconfiguration (properly deduplicate user tokens, checks static url links and result url_map)

Performs refactoring for CRDRef fetching. Use generic interface and reduce copy-paste.

Introduce new status field for VMUser - `lastSyncError`. Adds column print for it.

#1047
Signed-off-by: f41gh7 <[email protected]>
@f41gh7 f41gh7 mentioned this issue Jul 29, 2024
Merged
f41gh7 added a commit that referenced this issue Jul 30, 2024
@f41gh7
Merge branch 'master' into gh-1047
da7aa17
f41gh7 added a commit that referenced this issue Jul 30, 2024
@f41gh7
api/vmuser: adds status.lastSyncError (#1049)
a2ff4b1 
Changes behaviour of VMAuth config generation:
* now it skips misconfigured VMUser objects and continues config generation without it
* misconfigured VMUsers marked with error at lastSyncError field
* configuration checks better for misconfiguration (properly deduplicate user tokens, checks static url links and result url_map)

Performs refactoring for CRDRef fetching. Use generic interface and reduce copy-paste.

Introduce new status field for VMUser - `lastSyncError`. Adds column print for it.

#1047

Signed-off-by: f41gh7 <[email protected]>
@AndrewChubatiuk AndrewChubatiuk added the waiting for release The change was merged to upstream, but wasn't released yet. label Aug 12, 2024
@AndrewChubatiuk
Copy link
Contributor

released in v0.47.0

@AndrewChubatiuk AndrewChubatiuk removed the waiting for release The change was merged to upstream, but wasn't released yet. label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f41gh7 f41gh7

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndrewChubatiuk @f41gh7