-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: moved CRD to subchart #1560
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you describe some benefits or issues which new type of CRDs deployment solves?
I'm not sure if I completely understand what exactly this PR addresses.
crd: | ||
# -- Enables CRD creation and management. With this option, if you remove this chart, all CRD resources will be deleted with it. | ||
create: true | ||
crds: | ||
# -- check if plain or templated CRDs should be created. | ||
# with this option set to `false`, all CRDs will be rendered from templates. | ||
# with this option set to `true`, all CRDs are immutable and require manual upgrade. | ||
plain: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this change makes it impossible to disabled CRDs deployment completely. Is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, next step is CRD management removal from k8s-stack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if plain or templated CRDs should be created.
I don't think user can understand the crds.plain
based on the name and description.
And from the operator chart's perspective, setting crds.plain=true
offers no advantages over crds.plain=false
, so it's only for k8s-stack chart to use, right? In that case, I still don't see the necessity to combine the two crd sources.
single place, with CRDs instead of having them both in operator and k8s stack managed differently (as templates in operator and as plain CRDs in k8s-stack) |
39085bb
to
26fd409
Compare
crd.enabled
tocrds.plain
, which instead of disabling CRDs templating, changes a mode in which CRDs should be rendered: as plain text CRDs or as templates