victoria-metrics-cluster: allow excluding vmstorage node from vminser…

…t's storage node list (#1552)
VictoriaMetrics · Oct 3, 2024 · 9474517 · 9474517
1 parent 2c68c4d
commit 9474517
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 5 deletions.
diff --git a/charts/victoria-metrics-cluster/CHANGELOG.md b/charts/victoria-metrics-cluster/CHANGELOG.md
@@ -1,8 +1,9 @@
 ## Next release
 
 - Support extra storageNodes. Fail if no storageNodes set
-- Support enabling automatic discovery of vmstorage addresses using DNS SRV records in enterprise version.
+- Support enabling automatic discovery of vmstorage addresses using DNS SRV records in enterprise version
 - Added HPA with scaledown disabled by default
+- Allow excluding vmstorage nodes from vminsert. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/1549)
 
 ## 0.14.0
 

diff --git a/charts/victoria-metrics-cluster/README.md b/charts/victoria-metrics-cluster/README.md
@@ -1254,6 +1254,17 @@ timeoutSeconds: 5
 </pre>
 </td>
       <td><p>Specify alternative source for env variables</p>
+</td>
+    </tr>
+    <tr>
+      <td>vminsert.excludeStorageIDs</td>
+      <td>list</td>
+      <td><pre class="helm-vars-default-value" language-yaml" lang="plaintext">
+<code class="language-yaml">[]
+</code>
+</pre>
+</td>
+      <td><p>IDs of vmstorage nodes to exclude from writing</p>
 </td>
     </tr>
     <tr>
@@ -2374,7 +2385,7 @@ loggerFormat: json
       <td>vmselect.name</td>
       <td>string</td>
       <td><pre class="helm-vars-default-value" language-yaml" lang="">
-<code class="language-yaml">vmselect
+<code class="language-yaml">""
 </code>
 </pre>
 </td>

diff --git a/charts/victoria-metrics-cluster/templates/_helpers.tpl b/charts/victoria-metrics-cluster/templates/_helpers.tpl
@@ -109,9 +109,11 @@ app: {{ $Values.vmauth.name | default "vmauth" }}
     {{- else }}
       {{- $port := "8400" }}
       {{- range $i := until ($storage.replicaCount | int) -}}
-        {{- $_ := set $ "appIdx" $i }}
-        {{- $storageNode := include "vm.fqdn" $ -}}
-        {{- $storageNodes = append $storageNodes (printf "%s:%s" $storageNode $port) -}}
+        {{- if not (has (float64 $i) $app.excludeStorageIDs) -}}
+          {{- $_ := set $ "appIdx" $i }}
+          {{- $storageNode := include "vm.fqdn" $ -}}
+          {{- $storageNodes = append $storageNodes (printf "%s:%s" $storageNode $port) -}}
+        {{- end -}}
       {{- end -}}
       {{- $_ := unset $ "appIdx" }}
     {{- end }}

diff --git a/charts/victoria-metrics-cluster/values.yaml b/charts/victoria-metrics-cluster/values.yaml
@@ -342,6 +342,8 @@ vmselect:
 vminsert:
   # -- Enable deployment of vminsert component. Deployment is used
   enabled: true
+  # -- IDs of vmstorage nodes to exclude from writing
+  excludeStorageIDs: []
   # -- VMInsert name
   name: ""
   # -- VMInsert strategy