Removed link to misleading information about Thanos #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi 👋 While this item was true for like first 5 months of Thanso existence (until Feb 2018), currently Thanos project totally removed gossip protocol in last release and disabled couple months ago, so that information is no longer true. (:
valyala
added a commit
that referenced
this pull request
Jun 17, 2019
… of a link to document about Gossip protocol removal from Thanos Thanos removed non-working gossip protocol a few months ago - thanos-io/thanos#734 , so the link to the design document https://github.com/improbable-eng/thanos/blob/master/docs/proposals/approved/201809_gossip-removal.md became unavailable. So use a link to Wikipedia article instead. Closes #68
|
Thanks! Quick question what's the difference between |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
While this item was true for like first 4 months of Thanos existence (until ~Feb 2018 when we added other means for discovery), currently Thanos project totally removed gossip protocol in last release and disabled couple months ago, so that information is no longer true. (:
Cheers!