support current user in Query Trait #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @gregumo, @paulandrieux and @scrutinizer-auto-fixer to be potential reviewers |
| if (is_object($this->getCurrentUser())) { | ||
| $itemsQueryBuilder->setParameter('currentUser', $this->getCurrentUser()->getId()); | ||
| } else { | ||
| throw new AccessDeniedException(); |
There was a problem hiding this comment.
When the client is not logged, wouldn't be better showing blank instead of throwing an exception?
There was a problem hiding this comment.
I wasn't able to find a case where we would like to have such a widget in an anonymous scope but why not.
To go further, I think we could just do not run the query if there is the :currentUser parameter and no user authenticated
lenybernard
pushed a commit
that referenced
this pull request
Mar 16, 2016
…y-trait support current user in Query Trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case like, we want to be able to filter the query according to the current user.
Now, we just need to have some BusinessEntity with a User relation and use
:currentUserin the query input:JOIN item.user WHERE u.id = :currentUser