Improve GitHub actions. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't be merged until #101 fixes the |
nnethercote
force-pushed
the
run-tests-on-CI
branch
from
5918847
to
f4707ba
Compare
|
Note that the CI actions ran for this PR (good!) and also failed due to the failing tests (good!). |
`mdbook test` isn't run on CI! It should be. Plus some other CI improvements, based on the equivalent file at `github.com/nnethercote/perf-book/`: - Run actions on pull requests, to allow tests to run before merging. - Add some missing names for steps. - Update `actions/checkout` from v2 to v3.
Veykril
force-pushed
the
run-tests-on-CI
branch
from
f4707ba
to
4da6afc
Compare
|
Rebased it to see whether CI turns green (which it does) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdbook testisn't run on CI! It should be.Plus some other CI improvements, based on the equivalent file at
github.com/nnethercote/perf-book/:actions/checkoutfrom v2 to v3.