Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Format fails build in most sensible configurations #268

Closed
wants to merge 5 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/flutter_package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ on:
required: false
type: string
default: "80"
format_skip:
required: false
type: boolean
default: false
min_coverage:
required: false
type: number
Expand Down Expand Up @@ -102,7 +106,9 @@ jobs:

- name: ✨ Check Formatting
run: dart format --line-length ${{inputs.format_line_length}} --set-exit-if-changed ${{inputs.format_directories}}

if: "${{inputs.format_skip}} != true}}"
romanr marked this conversation as resolved.
Show resolved Hide resolved
run: dart format --line-length ${{inputs.format_line_length}} --set-exit-if-changed ${{inputs.format_directories}}

- name: 🕵️ Analyze
run: flutter analyze ${{inputs.analyze_directories}}

Expand Down