Use the router mathFilter for validating

Verseghy · Oct 28, 2023 · 943d7a4 · 943d7a4
1 parent cfd668e
commit 943d7a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/root.tsx b/src/root.tsx
@@ -14,6 +14,9 @@ import { homeRouteData } from './state/home'
 const ROUTES: RouteDefinition[] = [
   {
     path: '/posts/:id',
+    matchFilters: {
+      id: (id: string) => Number.isSafeInteger(parseInt(id)),
+    },
     component: lazy(() => import('~/pages/Post')),
     data: postRouteData,
   },

diff --git a/src/state/post.ts b/src/state/post.ts
@@ -33,20 +33,14 @@ type Response = {
   post: Post
 }
 
-export const postRouteData = ({ params, navigate }: RouteDataArgs) => {
-  const parsedId = parseInt(params.id)
-
-  if (!Number.isSafeInteger(parsedId)) {
-    navigate('/404')
-    return
-  }
-
+export const postRouteData = ({ params }: RouteDataArgs) => {
+  const id = Number(params.id)
   const newQuery = createGraphQLClient(GRAPHQL_BACKEND_URL)
 
   const [data] = newQuery<Response>(
     QUERY,
     {
-      id: parsedId,
+      id,
     },
     {
       deferStream: true,