Skip to content

Commit

Permalink
Removing the TODO from the committed code.
Browse files Browse the repository at this point in the history
I made a note in ticket angular#2621 about the type mismatch.
  • Loading branch information
appsforartists committed Jun 5, 2013
1 parent 979932e commit c716328
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions src/ng/rootScope.js
Original file line number Diff line number Diff line change
Expand Up @@ -416,17 +416,6 @@ function $RootScopeProvider(){
return;
}

/* TODO:
*
* - Find a way to stop calling listener for no damned reason:
* - Try checking newChangeNumber against oldChangeNumber
* - If that doesn't work, try setting a boolean in watchCollectionWatch and testing it in watchCollectionAction
*
* - Keep the types the same between oldCollection and newCollection. If you can't find a good way to do that
* in Angular, try setting the prototypes to be the same. This isn't perfect (the objects won't have internal
* state), but it's closer. If neither of these work, you can try casting newCollection to the same type as oldCollection
* and comparing them before calling listener.
*/
var newLength, key, i;

listener(newValue, oldValue, self);
Expand Down

0 comments on commit c716328

Please sign in to comment.