Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBP support for BoundSlice #13

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

hx507
Copy link
Contributor

@hx507 hx507 commented Oct 17, 2021

Hi! It seems like the current IBP implementation will yield error if the model contains Slice operations.

It seems simple to fix that. Please educate me if the fix looks wrong.

While slice is monotone, it have multiple parameters and can not use the default IBP method implemented in the base class
@huanzhang12
Copy link
Member

@hx507 Thank you so much for your contribution!
@shizhouxing Can you take a look at the changes and merge this into our next release?

@shizhouxing
Copy link
Member

shizhouxing commented Oct 17, 2021

Thanks @hx507!

@huanzhang12 It looks great. Shall I create a develop branch and merge this commit to develop? Later we can add our commits to develop and then merge them to master together? Or do we directly merge it to master? I think we need to ensure commits from the community are not squashed in future releases.

@shizhouxing shizhouxing changed the base branch from master to develop October 18, 2021 18:37
@shizhouxing shizhouxing merged commit 2c68627 into Verified-Intelligence:develop Oct 18, 2021
@huanzhang12
Copy link
Member

@shizhouxing Thanks for merging it! Yes this commit can stay in develop for now, and we will update the master branch in our next release (which will be in late October).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants