Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAN-424] Add lit tests for debug info generated by circom frontend #61

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

tim-hoffman
Copy link

@tim-hoffman tim-hoffman commented Oct 18, 2023

This PR is mainly tests (that I've been meaning to add for a while now) to ensure the debug information is generated properly. There is also one minor change to the LoadBucket to skip setting the active location from that bucket because it caused line numbers to be slightly confusing in some cases.

@tim-hoffman tim-hoffman self-assigned this Oct 18, 2023
Copy link

@iangneal iangneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tim-hoffman tim-hoffman merged commit df2f92c into llvm Oct 27, 2023
3 checks passed
@tim-hoffman tim-hoffman deleted the th/van-424 branch October 27, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants