[VAN-1370] handle non-scalar function parameters in BucketInterpreter #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-hoffman
commented
Jun 26, 2024
| //CHECK-NEXT: %[[T14:[0-9a-zA-Z_.]+]] = mul i32 2, %[[T13]] | ||
| //CHECK-NEXT: %[[T15:[0-9a-zA-Z_.]+]] = add i32 %[[T14]], 0 | ||
| //CHECK-NEXT: %[[T16:[0-9a-zA-Z_.]+]] = getelementptr [0 x i256], [0 x i256]* %lvars, i32 0, i32 %[[T15]] | ||
| //CHECK-NEXT: %[[COPY_SRC_0:[0-9a-zA-Z_.]+]] = getelementptr i256, i256* %[[T16]], i32 0 |
There was a problem hiding this comment.
I realize this looks like a regression; what was fixed indexing via a parameter has become dynamic indexing. However, this is actually caused by a different long-standing issue https://veridise.atlassian.net/browse/VAN-671 and the fix to the interpreter has brought it to the surface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.