Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support patching properly #36

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: support patching properly #36

merged 2 commits into from
Sep 25, 2023

Conversation

sorawee
Copy link

@sorawee sorawee commented Sep 22, 2023 •
edited
Loading

This PR consists of two commits.

  • The first commit adds the patching feature properly via --patch-circom.
  • The second commit switches the current tests to use this new flag.

@sorawee sorawee marked this pull request as draft September 22, 2023 21:59
@sorawee sorawee marked this pull request as ready for review September 23, 2023 00:28
@sorawee sorawee changed the title [DO NOT MERGE] feat: support patching properly feat: support patching properly Sep 23, 2023
shankarapailoor
shankarapailoor approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@shankarapailoor shankarapailoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shankarapailoor shankarapailoor merged commit 2bf2874 into Veridise:main Sep 25, 2023
5 checks passed
@sorawee sorawee deleted the add-patching branch September 25, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shankarapailoor shankarapailoor shankarapailoor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorawee @shankarapailoor