Use temporary directory more effectively #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have a proper per-run temp directory, we can put generated smt2 files in the temp directory, so that the files do not clutter the main temp directory, and so that the files will be cleaned up when Picus finishes execution.
Picus initially never clean up temporary files. However, the last commit changed this so that temporary files are cleaned up. Sometimes, though, we really do not want to clean up files (e.g. in order to generate smt2 files for debugging purposes). This commit adds the flag to control whether to run the clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Picus never cleans up smt2 files, and put them all in the top-level temporary directory, causing it to be cluttered with many Picus files.
This commit puts the generated smt2 files in a proper per-run temporary directory (introduced in #33), which by default will also get deleted afterward.
A separate commit adds an ability to retain the temporary files via
--nocleanin case the user wants to see the generated smt2 files for debugging purposes.