Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the output format to circom variables #3

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

sorawee
Copy link

@sorawee sorawee commented Aug 21, 2023

Prior this commit, the counterexample output format is defaulted to r1cs signals (although the help page incorrectly says otherwise). This commit fixes the help page and at the same time switches the default format to circom variables, since the format is more readable for clients. The flag --raw-output can still be used to view the r1cs signals, which could be useful for debugging.

Prior this commit, the counterexample output format is defaulted to r1cs
signals (although the help page incorrectly says otherwise).
This commit fixes the help page and at the same time switches
the default format to circom variables, since the format is more
readable for clients. The flag `--raw-output` can still be used to view
the r1cs signals, which could be useful for debugging.
Copy link
Collaborator

@shankarapailoor shankarapailoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shankarapailoor shankarapailoor merged commit 65f0ebe into Veridise:main Aug 21, 2023
4 checks passed
@sorawee sorawee deleted the change-output-format-default branch August 21, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants