Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with coq-interval.4.7.0 #17

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

JasonGross
Copy link
Contributor

The relevant change in coq-interval is

diff --git a/src/Tactic.v b/src/Tactic.v
index 6aec7b6..de2181d 100644
--- a/src/Tactic.v
+++ b/src/Tactic.v
@@ -53,7 +53,7 @@ Module I1 := FloatIntervalFull F.
 Module IT1 := IntegralTacticAux F I1.
 Module PT1 := PlotTacticAux F I1.
 Module RT1 := RootTacticAux F I1.
-Module I2 := FloatIntervalFull Tactic_float.Float.
+Module I2 := Tactic_float.Interval.
 Module IT2 := IntegralTacticAux Tactic_float.Float I2.
 Module PT2 := PlotTacticAux Tactic_float.Float I2.
 Module RT2 := RootTacticAux Tactic_float.Float I2.

I have no idea what I'm doing, but the import seems to be unused?

The relevant change in coq-interval is
```diff
diff --git a/src/Tactic.v b/src/Tactic.v
index 6aec7b6..de2181d 100644
--- a/src/Tactic.v
+++ b/src/Tactic.v
@@ -53,7 +53,7 @@ Module I1 := FloatIntervalFull F.
 Module IT1 := IntegralTacticAux F I1.
 Module PT1 := PlotTacticAux F I1.
 Module RT1 := RootTacticAux F I1.
-Module I2 := FloatIntervalFull Tactic_float.Float.
+Module I2 := Tactic_float.Interval.
 Module IT2 := IntegralTacticAux Tactic_float.Float I2.
 Module PT2 := PlotTacticAux Tactic_float.Float I2.
 Module RT2 := RootTacticAux Tactic_float.Float I2.
```

I have no idea what I'm doing, but the import seems to be unused?
@andrew-appel andrew-appel merged commit 35a4c24 into VeriNum:master Aug 31, 2023
@JasonGross JasonGross deleted the fix-for-interval branch September 1, 2023 03:01
JasonGross added a commit to JasonGross/vcfloat that referenced this pull request Sep 22, 2023
With VeriNum#17 and VeriNum#19, VCFloat should build with Coq 8.18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants