Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alias support for queries and mutations #26

Merged
merged 28 commits into from
Oct 5, 2019

Conversation

PaulProject
Copy link
Contributor

No description provided.

VerachadW and others added 17 commits September 27, 2016 22:01
* Update Spek version

* Fix print wrong escaped character, Fix VerachadW#4

* Rewrite the GraphQLPrintSpek for preetty print test

* Bump hotfix version

* Update build status link
* bump to kotlin v1.1.1

* Add type alias for more readable code

* Change the package name to me.lazmaid.kraph

* Fix build failed dur to hamkrest error

* Update spek version

* Update ENV for release

* Update README
* WIP

* Split the print logic into sealed class

* Update UTs

* Add exception message

* Refactor
* Add Test Coverage

* Update spek version

* Fix test result path

* Add codecov YAML

* Add onlyIf

* Update config

* Fix travis command

* Add coverage badge
* Add support for boolean type

* Add Tests
missing "h" in the example call to `println(query.toGrapQueryString())`
* improve readme

* Allow using field with a block in place of field object

* Update readme to include new changes

* Cheap implementation of fragment that doesn't use actual GraphQL Fragments

* Add fragment docs to readme

* Fix tests

* Change function to 'defineFragment'
* Update .gitignore

* Update dependecies

* Add secondary constructor for DataEntry.NonDecimalNUmber

* Add Test for DataEntry classes

* Fix failed UTs
* improve readme

* Allow using field with a block in place of field object

* Update readme to include new changes

* Cheap implementation of fragment that doesn't use actual GraphQL Fragments

* Add fragment docs to readme

* Fix tests

* Add separate methods to print the different parts of the request separately

* Use spaces instead of newlines for request format

* Rewrite printing operations to optionally escape quotes

* update readme a bit

* Change function to 'defineFragment'

* Use an enum to choose print format and write tests to cover all formats

* Add note about variables
* add support for variables

* add support for variables
@VerachadW
Copy link
Owner

Hey @PaulProject. Thanks for the PR. Could you please check the errors from CI Build and add some example for usage as well?

@PaulProject
Copy link
Contributor Author

I have a problem with run JUnit tests. I installed Spek plugin for AS 3.2.1, run tests and see error:

WARNING: TestEngine with ID 'spek' failed to discover tests
org.junit.platform.commons.util.PreconditionViolationException: Could not load class with name: me.lazmaid.kraph.test.DataEntrySpek

@PaulProject
Copy link
Contributor Author

Hi, how are you?

@VerachadW
Copy link
Owner

@PaulProject Sorry for the delay. Quite busy here. I will check by today. Could you show me your version of Spek plugin? Did you have the latest version?

@VerachadW VerachadW changed the base branch from master to develop November 15, 2018 15:58
@VerachadW
Copy link
Owner

I just changed the target branch to develop. Try to update and rerun again

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #26 into develop will decrease coverage by 1.04%.
The diff coverage is 60%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #26      +/-   ##
=============================================
- Coverage      83.43%   82.38%   -1.05%     
- Complexity        69       70       +1     
=============================================
  Files             16       16              
  Lines            157      159       +2     
  Branches          29       30       +1     
=============================================
  Hits             131      131              
- Misses             9       10       +1     
- Partials          17       18       +1
Impacted Files Coverage Δ Complexity Δ
...rc/main/kotlin/me/lazmaid/kraph/lang/relay/Node.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
core/src/main/kotlin/me/lazmaid/kraph/Kraph.kt 85.18% <100%> (ø) 12 <0> (ø) ⬇️
...otlin/me/lazmaid/kraph/lang/relay/RelayMutation.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...ore/src/main/kotlin/me/lazmaid/kraph/lang/Field.kt 60% <33.33%> (-15%) 7 <4> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e689d...0d286ce. Read the comment docs.

@PaulProject
Copy link
Contributor Author

Hello, Verachad. I'm ready to merge. Do you know, GitHub is able squash commits when merge request is accepted?

@VerachadW
Copy link
Owner

@PaulProject Hey, I think we are good to merge. Could you also write HOW-TO in README.md as well?

@PaulProject
Copy link
Contributor Author

Yes of course, give me some time

Pavel Sukhoterin added 2 commits November 22, 2018 14:27
# Conflicts:
#	README.md
#	core/src/main/kotlin/me/lazmaid/kraph/Kraph.kt
#	core/src/main/kotlin/me/lazmaid/kraph/lang/DataEntry.kt
#	core/src/main/kotlin/me/lazmaid/kraph/lang/Field.kt
#	core/src/main/kotlin/me/lazmaid/kraph/lang/GraphQLNode.kt
#	core/src/main/kotlin/me/lazmaid/kraph/lang/relay/Node.kt
#	core/src/main/kotlin/me/lazmaid/kraph/lang/relay/RelayMutation.kt
#	core/src/test/kotlin/me/lazmaid/kraph/test/BuilderSpek.kt
#	core/src/test/kotlin/me/lazmaid/kraph/test/DataEntrySpek.kt
#	core/src/test/kotlin/me/lazmaid/kraph/test/GraphQLPrintSpek.kt
#	core/src/test/kotlin/me/lazmaid/kraph/test/RequestSpek.kt
@PaulProject
Copy link
Contributor Author

PaulProject commented Nov 22, 2018

I have some conflicts. Do I need to resolve it?

@PaulProject
Copy link
Contributor Author

I resolve the conflicts, do I need to push the change?

@VerachadW
Copy link
Owner

@PaulProject Yes, please

@PaulProject
Copy link
Contributor Author

Hi @VerachadW, what do you think about code coverage? Do I need to fix the checks?

@VerachadW
Copy link
Owner

@PaulProject Yes, please.

@VerachadW
Copy link
Owner

@PaulProject How was the coverage? Could you be able to fix it? It wants to have 1 version release before next year. If possible, I want your changes as well.

@PaulProject
Copy link
Contributor Author

Hi, I don’t have any time for fix it. I have a problem with run the tests (I wrote about it) and I can’t check the code coverage. If you can help me, we do it.

@VerachadW VerachadW merged commit 2b39841 into VerachadW:develop Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants