Add enums support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Spek version * Fix print wrong escaped character, Fix VerachadW#4 * Rewrite the GraphQLPrintSpek for preetty print test * Bump hotfix version * Update build status link
* bump to kotlin v1.1.1 * Add type alias for more readable code * Change the package name to me.lazmaid.kraph * Fix build failed dur to hamkrest error * Update spek version * Update ENV for release * Update README
* WIP * Split the print logic into sealed class * Update UTs * Add exception message * Refactor
* Add Test Coverage * Update spek version * Fix test result path * Add codecov YAML * Add onlyIf * Update config * Fix travis command * Add coverage badge
* Add support for boolean type * Add Tests
missing "h" in the example call to `println(query.toGrapQueryString())`
* improve readme * Allow using field with a block in place of field object * Update readme to include new changes * Cheap implementation of fragment that doesn't use actual GraphQL Fragments * Add fragment docs to readme * Fix tests * Change function to 'defineFragment'
* Update .gitignore * Update dependecies * Add secondary constructor for DataEntry.NonDecimalNUmber * Add Test for DataEntry classes * Fix failed UTs
* improve readme * Allow using field with a block in place of field object * Update readme to include new changes * Cheap implementation of fragment that doesn't use actual GraphQL Fragments * Add fragment docs to readme * Fix tests * Add separate methods to print the different parts of the request separately * Use spaces instead of newlines for request format * Rewrite printing operations to optionally escape quotes * update readme a bit * Change function to 'defineFragment' * Use an enum to choose print format and write tests to cover all formats * Add note about variables
* add support for variables * add support for variables
|
Hi, Thanks for the PR. Could you also add test here as well? I will check in this weekends. |
|
Hi, sorry for late answer. I tried write the test, but I can't run it. Can you help me with test? |
|
Sure. Did you already install Spek plugin? If yes, could you show me what
kind of error you got?
On Wed, Nov 7, 2018 at 4:19 AM makarenkoanton ***@***.***> wrote:
Hi, sorry for late answer. I tried write the test, but I can't run it. Can
you help me with test?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#25 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AE6jE9Sd6NYWXsSa1ncY2FUCgNJUoW3Gks5usfzlgaJpZM4YJOgY>
.
--
Regards,
Verachad Wongsawangtham
|
Codecov Report
@@ Coverage Diff @@
## develop #25 +/- ##
==========================================
Coverage 83.43% 83.43%
Complexity 69 69
==========================================
Files 16 16
Lines 157 157
Branches 29 29
==========================================
Hits 131 131
Misses 9 9
Partials 17 17
Continue to review full report at Codecov.
|
|
Hi, thank you, I installed Spek plugin, and now I can run test. I wrote some tests, and tried to coverage new enum type, but now i don't understand, what i need more to do for successful codecov's job |
|
From what I checked, CodeCov shows that your coverage is missing 1 branch here. From your testing, I suspected that it matches the condition of the |
|
I just change the target branch to |
# Conflicts: # build.gradle
|
@VerachadW hi, do you have some time to check this PR?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it's my first pull request. I tried to add support of enums type.