-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPF-242] Loading components DLR-Search & DLR-Profile #138
base: main
Are you sure you want to change the base?
Conversation
Terraform Format and Style 🖌
|
apps/frontend/src/pages/Profil/subcomponents/DienstleisterProfil.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so far, konnte es jz zeitlich doch noch nicht austesten, ansonsten eben was Malte meint
Terraform Format and Style 🖌
|
Terraform Format and Style 🖌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sieht super aus, danke dass du den loading indicator noch in eine Komponente gezogen hast!
Ich muss die Sachen noch beim create/update/delete im DLR Profil einbauen im Button. Noch nicht zu gekommen. Würde ich auch noch in dieser PR machen sofern ich zu komme. ^^ |
Closes: GPF-242
Comments
Added the loading components for DLR-Search and for opening the DLR-Profile Page.
I dont think we need loading components for creating and deleting the Dienstleister due to the fact that most of the time there is no coldstart when doing that. What do you think about that? Should we add those anyway?
I also fixed the background and address deleted on first search bug for DLR-Search. (GPF-282)
Still another bug left which I was not able to fix. It has something to do with out font.
But its probably not necessary to fix it, if @kai-konitzer will change the design anyways.
Changes