feat: add "Reset Vesktop" option to menu & tray #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure whether to make this button also clear Vencord Desktop settings or not, could be a good idea |
|
How do you even use this entry now that we hid the menubar? |
|
Should I also add this in Vencord Desktop Settings then? (It's available on macOS since the menu bar is always there) |
|
having it in the tray would likely be the most logical
|
ryanccn
force-pushed
the
menu-bar-clear-data
branch
from
4a565c9
to
aa9e7ca
Compare
Vendicated
reviewed
Jul 13, 2023
Vendicated
reviewed
Jul 13, 2023
Vendicated
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Aside my other proposed changes,
- Please update the name from Vencord Desktop to Vesktop
"reset Vesktop" kind of implies that Vesktop settings are also reset, which is not actually the case. We should either also reset those settings or rephrase itNevermind I entirely missed the rmdir line
Vendicated
approved these changes
Jul 14, 2023
Vendicated
changed the title
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.