Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Convert-TppObject, Find-TppObject path tweak, other fixes #49

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Add Convert-TppObject, Find-TppObject path tweak, other fixes #49

merged 2 commits into from
Dec 6, 2021

Conversation

gdbarron
Copy link
Collaborator

@gdbarron gdbarron commented Dec 6, 2021

  • BREAKING CHANGE: change parameter -NewName to -NewPath in Rename-TppObject to allow moving an object in addition to renaming
  • Add Convert-TppObject to change the class/type of an existing object
  • Fix typos in examples for Add-TppCertificateAssociation and Remove-TppCertificateAssociation
  • Set the default for -Path in Find-TppObject to \ved\policy. Running Find-TppObject without a path will now recursively search from \ved\policy.
  • Add additional pipeline options to Get-TppAttribute
  • Add help and examples to Invoke-VenafiRestMethod, #48
  • Set VenafiSession default value in Invoke-VenafiRestMethod, #47

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

PSScriptAnalyzer results:

Errors: [0], Warnings: [0], Information: [33]


RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 72
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 73
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 74
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 75
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 76
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 77
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 78
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 79
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 80
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 81
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 82
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 83
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 84
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 85
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 86
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 87
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 88
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 89
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 90
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 91
Message    : Line has trailing whitespace

RuleName   : PSAvoidTrailingWhitespace
Severity   : Information
ScriptName : VenafiPS.psd1
Line       : 92
Message    : Line has trailing whitespace

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppIdentityFormat.ps1
Line       : 16
Message    : The cmdlet 'Test-TppIdentityFormat' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 14
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 17
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 19
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : ConvertTo-TppGuid.ps1
Line       : 74
Message    : The cmdlet 'ConvertTo-TppGuid' returns an object of type 
             'System.Guid' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Find-TppCodeSignEnvironment.ps1
Line       : 67
Message    : The cmdlet 'Find-TppCodeSignEnvironment' returns an object of type 
             'TppObject' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : New-TppObject.ps1
Line       : 159
Message    : The cmdlet 'New-TppObject' returns an object of type 'TppObject' 
             but this type is not declared in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppToken.ps1
Line       : 175
Message    : The cmdlet 'Test-TppToken' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppToken.ps1
Line       : 179
Message    : The cmdlet 'Test-TppToken' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : New-TppCertificate.ps1
Line       : 269
Message    : The cmdlet 'New-TppCertificate' returns an object of type 
             'TppObject' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Find-TppObject.ps1
Line       : 219
Message    : The cmdlet 'Find-TppObject' returns an object of type 'TppObject' 
             but this type is not declared in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-TppVersion.ps1
Line       : 50
Message    : The cmdlet 'Get-TppVersion' returns an object of type 
             'System.Version' but this type is not declared in the OutputType 
             attribute.

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

PSScriptAnalyzer results:

Errors: [0], Warnings: [0], Information: [12]


RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppIdentityFormat.ps1
Line       : 16
Message    : The cmdlet 'Test-TppIdentityFormat' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 14
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 17
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-VenafiAuthType.ps1
Line       : 19
Message    : The cmdlet 'Get-VenafiAuthType' returns an object of type 
             'System.String' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : ConvertTo-TppGuid.ps1
Line       : 74
Message    : The cmdlet 'ConvertTo-TppGuid' returns an object of type 
             'System.Guid' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Find-TppCodeSignEnvironment.ps1
Line       : 67
Message    : The cmdlet 'Find-TppCodeSignEnvironment' returns an object of type 
             'TppObject' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : New-TppObject.ps1
Line       : 159
Message    : The cmdlet 'New-TppObject' returns an object of type 'TppObject' 
             but this type is not declared in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppToken.ps1
Line       : 175
Message    : The cmdlet 'Test-TppToken' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Test-TppToken.ps1
Line       : 179
Message    : The cmdlet 'Test-TppToken' returns an object of type 
             'System.Boolean' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : New-TppCertificate.ps1
Line       : 269
Message    : The cmdlet 'New-TppCertificate' returns an object of type 
             'TppObject' but this type is not declared in the OutputType 
             attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Find-TppObject.ps1
Line       : 219
Message    : The cmdlet 'Find-TppObject' returns an object of type 'TppObject' 
             but this type is not declared in the OutputType attribute.

RuleName   : PSUseOutputTypeCorrectly
Severity   : Information
ScriptName : Get-TppVersion.ps1
Line       : 50
Message    : The cmdlet 'Get-TppVersion' returns an object of type 
             'System.Version' but this type is not declared in the OutputType 
             attribute.

@gdbarron gdbarron merged commit 42d768d into main Dec 6, 2021
@gdbarron gdbarron deleted the 20211202 branch December 6, 2021 18:39
This was linked to issues Dec 6, 2021
Invoke-VenafiRestMethod Lacks Details and Examples #48
Closed
Invoke-VenafiRestMethod Requires -VenafiSession Parameter #47
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invoke-VenafiRestMethod Lacks Details and Examples Invoke-VenafiRestMethod Requires -VenafiSession Parameter
1 participant
@gdbarron