Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support more chars for friendly name in Test-TppIdentityFormat #206

Merged
merged 1 commit into from
May 4, 2023
Merged

support more chars for friendly name in Test-TppIdentityFormat #206

merged 1 commit into from
May 4, 2023

Conversation

gdbarron
Copy link
Collaborator

@gdbarron gdbarron commented May 3, 2023

fix #205

@gdbarron gdbarron self-assigned this May 3, 2023
@gdbarron gdbarron linked an issue May 3, 2023 that may be closed by this pull request
Domain Identities with period not supported #205
Closed
Saadi6
Saadi6 approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@Saadi6 Saadi6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appear to work.

PS C:\temp\VSE_3> Get-VenafiIdentity -id "AD+BigSur.local:john.doe"

Name : john.doe
ID : AD+bigsur.local:27e54f90df7cb5448837f571f5955289
Path : CN=John Doe,OU=Users,OU=Maple,DC=BigSur,DC=local
FullName : AD+bigsur.local:john.doe
IsGroup : False

  •    :

PS C:\temp\VSE_3> Get-VenafiIdentity -id "AD+bigsur.local:27e54f90df7cb5448837f571f5955289"

Name : john.doe
ID : AD+bigsur.local:27e54f90df7cb5448837f571f5955289
Path : CN=John Doe,OU=Users,OU=Maple,DC=BigSur,DC=local
FullName : AD+bigsur.local:john.doe
IsGroup : False

  •    :

@gdbarron gdbarron merged commit cb6b969 into main May 4, 2023
@gdbarron gdbarron deleted the 205-domain-identities-with-period-not-supported branch May 4, 2023 12:26
@gdbarron gdbarron mentioned this pull request May 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadi6 Saadi6 Saadi6 approved these changes

@wilddev65 wilddev65 Awaiting requested review from wilddev65

@astro2000j astro2000j Awaiting requested review from astro2000j

@Pmaraveyias Pmaraveyias Awaiting requested review from Pmaraveyias

@danguite-ven danguite-ven Awaiting requested review from danguite-ven

@vertigo-one vertigo-one Awaiting requested review from vertigo-one

@kswordfish kswordfish Awaiting requested review from kswordfish

Assignees

@gdbarron gdbarron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Domain Identities with period not supported
2 participants
@gdbarron @Saadi6