Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivial] Fix clang warning: 'csize' not initialized. #965

Merged
merged 1 commit into from
Sep 25, 2021
Merged

[Trivial] Fix clang warning: 'csize' not initialized. #965

merged 1 commit into from
Sep 25, 2021

Conversation

Zannick
Copy link
Collaborator

@Zannick Zannick commented Sep 19, 2021

Initialize the keyValueMap directly from s instead.

@Zannick
Fix clang warning: 'csize' not initialized.
808b5b6 
Initialize the keyValueMap directly from s instead.
@Zannick Zannick added Component: Core App Related to the application itself. Dev Status: Open PR The work for this issue is done, and waiting to be merged. Tag: Waiting For Code Review Waiting for code review from a core developer labels Sep 19, 2021
@Zannick Zannick self-assigned this Sep 19, 2021
@Zannick Zannick removed the Dev Status: Open PR The work for this issue is done, and waiting to be merged. label Sep 19, 2021
@CaveSpectre11 CaveSpectre11 requested review from WetOne and removed request for blondfrogs September 20, 2021 10:41
CaveSpectre11
CaveSpectre11 approved these changes Sep 25, 2021
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 808b5b6

@CaveSpectre11 CaveSpectre11 added Code Review: Passed and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Sep 25, 2021
@CaveSpectre11 CaveSpectre11 merged commit 6c4f8b2 into Veil-Project:master Sep 25, 2021
@CaveSpectre11 CaveSpectre11 added the Dev Status: Merged Issue is completely finished. label Sep 25, 2021
@Zannick Zannick deleted the warnings branch October 22, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaveSpectre11 CaveSpectre11 CaveSpectre11 approved these changes

@codeofalltrades codeofalltrades Awaiting requested review from codeofalltrades

@WetOne WetOne Awaiting requested review from WetOne

Assignees

@Zannick Zannick

Labels
Code Review: Passed Component: Core App Related to the application itself. Dev Status: Merged Issue is completely finished. Tag: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zannick @CaveSpectre11