Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Set minimum scrollbar height for transactions history list #1008

Merged
merged 1 commit into from
Jun 22, 2022
Merged

[GUI] Set minimum scrollbar height for transactions history list #1008

merged 1 commit into from
Jun 22, 2022

Conversation

us77ipis
Copy link
Contributor

@us77ipis us77ipis commented Jun 9, 2022

Fixes #1007

@us77ipis
Copy link
Contributor Author

us77ipis commented Jun 9, 2022

@seanPhill is this minimum size ok or do you want it bigger / smaller?

@seanPhill
Copy link
Collaborator

It works great! :)

@seanPhill seanPhill added QA: Passed This has passed QA testing and can be merged to master Tag: Waiting For Code Review Waiting for code review from a core developer labels Jun 9, 2022
@us77ipis us77ipis changed the title Set minimum scrollbar height for transactions history list [GUI] Set minimum scrollbar height for transactions history list Jun 9, 2022
Zannick
Zannick approved these changes Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@Zannick Zannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK df3126e

@Zannick Zannick added Component: GUI Primarily related to the display of the user interface Code Review: Passed and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Jun 18, 2022
@seanPhill seanPhill merged commit 81df0c8 into Veil-Project:master Jun 22, 2022
@us77ipis us77ipis deleted the min-scrollbar-height-transaction-history branch June 28, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zannick Zannick Zannick approved these changes

Assignees
No one assigned
Labels
Code Review: Passed Component: GUI Primarily related to the display of the user interface QA: Passed This has passed QA testing and can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Overview (transactions list) page scroll bar needs a minimum size in order to be usable
3 participants
@us77ipis @seanPhill @Zannick