Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Fix version #191

Closed
wants to merge 1 commit into from
Closed

Fix version #191

wants to merge 1 commit into from

Conversation

leesoh
Copy link
Contributor

@leesoh leesoh commented Apr 12, 2018

osversion evaluates to something like "17.10", which fails the compare. I expect version was intended; this fixes the error on my Ubuntu 17.10 box so I fixed the others as well.

`osversion` evaluates to something like "17.10", which fails the compare. I expect `version` was intended; this fixes the error on my Ubuntu 17.10 box so I fixed the others as well.
@g0tmi1k
Copy link
Contributor

g0tmi1k commented Apr 12, 2018

Where is version being defined though in the setup?
I can't see version= or export version anywhere.

g0tmi1k added a commit to g0tmi1k/Veil that referenced this pull request Apr 12, 2018
@g0tmi1k
Copy link
Contributor

g0tmi1k commented Apr 12, 2018

Ah!
Then I suggest this: 3cacc35

@leesoh
Copy link
Contributor Author

leesoh commented Apr 12, 2018

Is beautiful. Carry on, I'll show myself out :D

@leesoh leesoh closed this Apr 12, 2018
@g0tmi1k
Copy link
Contributor

g0tmi1k commented Apr 12, 2018

<3
Thanks for the heads up on this (I didn't spot it & my grep fu failed!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants