Fix is_vector_type fail while building neon with clang or GCC > 10.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC with version 10 onward does not treat intrinsic type(int8x16_t) and __vector_type(vector_size(16) int8_t) are the same which lead to is_vector_type<Tp> failure. Meanwhile, clang use __attribute__((neon_vector_type)) is not same type with __attribute__((__vector_size__())) Above all, is_vector_type should be judged by logical "or" with the same<Tp, __vector_type> and same<Tp,__intrinsic_type> ChangeLog: * experimental/bits/simd.h: refactor the is_vector_type taking vector_type and intrinsic_type as independent types
yaozhongxiao
force-pushed
the
is_vector_type
branch
from
6c8f5bd
to
9a57678
Compare
|
@mattkretz please help to confirm the issue and the solution, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC with version 10 onward does not treat intrinsic type(int8x16_t)
and __vector_type(vector_size(16) int8_t) are the same which lead
to is_vector_type failure.
Meanwhile, clang use attribute((neon_vector_type)) is not same
type with attribute((vector_size()))
Above all, is_vector_type should be judged by logical "or"
with the same<Tp, __vector_type> and same<Tp,__intrinsic_type>