1.20 port #813
1.20 port #813
Conversation
|
If I'm not mistaken, this port works for 1.20. Would you be against uploading it yourself to curseforge until Vazkii is active on it? |
|
|
||
| cadAssembler = new BlockCADAssembler(Block.Properties.copy(metalBehaviour).strength(5, 10).sound(SoundType.METAL).noOcclusion()); | ||
| programmer = new BlockProgrammer(Block.Properties.copy(metalBehaviour).strength(5, 10).sound(SoundType.METAL).noOcclusion()); | ||
| cadAssembler = new BlockCADAssembler(Block.Properties.of().mapColor(MapColor.METAL).instrument(NoteBlockInstrument.IRON_XYLOPHONE).requiresCorrectToolForDrops().strength(5, 10).sound(SoundType.METAL).noOcclusion()); |
There was a problem hiding this comment.
Note: Blocks don't seem to have proper tools set up for breaking, conjured blocks are no longer instant punch
There was a problem hiding this comment.
@Kamefrede addet it in 85ef344
I don't know what his goal was but I think there should be at least a Tool that breaks them faster. Fixing it is not a problem but I neat to know what the goal is.
There was a problem hiding this comment.
It was just to get something quick and dirty out, I intended on fixing it later
There was a problem hiding this comment.
I removed the tool requirement.
| @@ -116,7 +113,7 @@ public static void register(RegisterEvent evt) { | |||
|
|
|||
| evt.register(ForgeRegistries.Keys.MENU_TYPES, helper -> { | |||
| helper.register(ForgeRegistries.BLOCKS.getKey(cadAssembler), containerCADAssembler); | |||
| DistExecutor.safeRunWhenOn(Dist.CLIENT, () -> () -> { | |||
| DistExecutor.unsafeRunWhenOn(Dist.CLIENT, () -> () -> { | |||
There was a problem hiding this comment.
Yes
Caused by: java.lang.RuntimeException: Unsafe Referent usage found in safe referent method
The olde runWhenOn function just wraps unsafeRunWhenOn.
@Deprecated
public static void runWhenOn(Dist dist, Supplier toRun) {
unsafeRunWhenOn(dist, toRun);
}
https://forums.minecraftforge.net/topic/96761-1165-properly-using-distexecutor-with-arguments/
No description provided.