Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] t2d: add ssh key to authorized_keys #212

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

antonag32
Copy link
Contributor

@antonag32 antonag32 commented Jan 16, 2024

Since /home/odoo/.ssh is marked as a volume in the parent image, changes to files in the directory during docker build are being lost when a new container is created. Therefore the authorized_keys file is set directly on the host and copied over to the container.

Closes #211.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (5b3e4fe) 81.71% compared to head (152109c) 80.61%.

Files Patch % Lines
src/travis2docker/travis2docker.py 44.44% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   81.71%   80.61%   -1.10%     
==========================================
  Files           7        7              
  Lines         596      614      +18     
  Branches      108      113       +5     
==========================================
+ Hits          487      495       +8     
- Misses         79       86       +7     
- Partials       30       33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since /home/odoo/.ssh is marked as a volume in the parent image, changes
to files in the directory during docker build are being lost when a new
container is created. Therefore the authorized_keys file is set directly
on the host and copied over to the container.

Closes Vauxoo#211.
@antonag32 antonag32 marked this pull request as draft January 17, 2024 20:01
@antonag32 antonag32 removed the request for review from luisg123v January 17, 2024 20:02
@antonag32 antonag32 marked this pull request as ready for review January 17, 2024 20:02
@antonag32 antonag32 requested a review from luisg123v January 17, 2024 20:02
Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@luisg123v luisg123v merged commit 001f7f0 into Vauxoo:main Jan 20, 2024
18 checks passed
@luisg123v luisg123v deleted the i211-anton branch January 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH access is not being granted to the local user
3 participants