-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] t2d: add new argument --build-extra-steps #210
Conversation
Previous CI and tox runs apparently lied. This is because tests run against the main branch upstream, and not against the source code. This generates false positives/negatives that are only found when a merge completes but spending time fixing it is not a priority as of now. Therefore the quickfix of adding the file back has been chosen.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 79.29% 79.36% +0.06%
==========================================
Files 7 7
Lines 594 596 +2
Branches 108 108
==========================================
+ Hits 471 473 +2
Misses 90 90
Partials 33 33
☔ View full report in Codecov by Sentry. |
12b4a5f
to
a37cff5
Compare
a37cff5
to
4376286
Compare
Tested with the following args:
And the resulting Dockerfile:
|
CI fails but that's because I deleted https://github.com/antonag32/travis2docker/actions/runs/6826672573 |
Similar to --run-extra-cmds, --build-extra-cmds, this new argument allows users to add extra steps at the end of the generated Dockerfile. Closes Vauxoo#209.
4376286
to
5aa6243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Similar to --run-extra-cmds, --build-extra-cmds, this new argument allows users to add extra steps at the end of the generated Dockerfile.
Closes #209.