[PR] Checkout and initialize wordpress-develop in /tmp/ #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installation of local npm packages was running into trouble due to what is likely a race condition caused by slow shared drives between the host and guest machines. This is mostly a guess, but seems plausible. We can instead handle the initial SVN checkout, the npm package installation, and the initial build via grunt in the VM's `/tmp` machine. Once this is all prepped, it is then moved to the final location in `/srv/www/wordpress-develop` before other scripts that install WordPress run. Anything involving files runs quite a bit quicker during the initial setup. The move of the directory takes a long while though, which kind of negates the original speed. :) But speed isn't the problem, incomplete local npm packages is. Fixes #825.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation of local npm packages was running into trouble
due to what is likely a race condition caused by slow shared drives
between the host and guest machines. This is mostly a guess, but
seems plausible.
We can instead handle the initial SVN checkout, the npm package
installation, and the initial build via grunt in the VM's
/tmpmachine. Once this is all prepped, it is then moved to the final
location in
/srv/www/wordpress-developbefore other scripts thatinstall WordPress run.
Anything involving files runs quite a bit quicker during the initial
setup. The move of the directory takes a long while though, which
kind of negates the original speed. :)
But speed isn't the problem, incomplete local npm packages is.
Fixes #825.