Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve relative paths in vvv-nginx.conf since not allowed by Nginx #852

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

westonruter
Copy link
Contributor

This allows for vvv-nginx.conf to be located in a project's subdirectory, like the private directory on Pantheon:

server {
    listen       80;
    listen       443 ssl;
    server_name  vvv.pantheon.example.com
    root         {vvv_path_to_folder}/..;
    include      /etc/nginx/nginx-wp-common.conf;
}

westonruter added a commit to xwp/pantheon-wordpress-upstream that referenced this pull request Mar 16, 2016
@lkwdwrd
Copy link
Contributor

lkwdwrd commented Mar 16, 2016

Yes! +1 for this!

Luke Woodward – Associate Director of Engineering
10up Inc. http://10up.com | [email protected] | @lkwdwrd

On Wed, Mar 16, 2016 at 1:25 PM, Weston Ruter [email protected]
wrote:

This allows for vvv-nginx.conf to be supplied in a project's
subdirectory, like the private directory on Pantheon:

server {
listen 80;
listen 443 ssl;
server_name vvv.pantheon.example.com
root {vvv_path_to_folder}/..;
include /etc/nginx/nginx-wp-common.conf;
}


You can view, comment on, or merge this pull request online at:

#852
Commit Summary

  • Resolve relative paths in vvv-nginx.conf since not allowed by Nginx

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#852

@westonruter westonruter force-pushed the feature/nginx-conf-relative-paths branch from 1376b23 to be239ac Compare March 16, 2016 19:03
@westonruter
Copy link
Contributor Author

@jeremyfelt shall I merge? 😄

@jeremyfelt
Copy link
Member

I missed this one. Looks excellent! 👍

@jeremyfelt jeremyfelt added this to the Next Release milestone Mar 31, 2016
@jeremyfelt jeremyfelt merged commit 9531b22 into develop Mar 31, 2016
@jeremyfelt jeremyfelt deleted the feature/nginx-conf-relative-paths branch March 31, 2016 05:41
@rheinardkorf
Copy link

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants