Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable #2617

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fix unbound variable #2617

merged 2 commits into from
Jun 15, 2022

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Jun 14, 2022

Ref: #2613

Checks

  • I've updated the changelog.
  • I've tested this PR
  • This PR is for the develop branch not the stable branch.
  • This PR is complete and ready for review.

@update-docs
Copy link

update-docs bot commented Jun 14, 2022 •
edited by unfurl-links bot
Loading

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub
The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

tomjn
tomjn previously approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Mte90
Copy link
Member Author

Mte90 commented Jun 14, 2022

I saw the error and some issues on backup without a log, so...

This fix :-)

@tomjn
Copy link
Member

tomjn commented Jun 14, 2022

@Mte90 lets get this in the changelog and then we can merge

@tomjn tomjn added this to the 3.10 milestone Jun 14, 2022
@Mte90 Mte90 requested a review from tomjn June 14, 2022 17:05
@tomjn tomjn merged commit 7b30a6e into develop Jun 15, 2022
@tomjn
Copy link
Member

tomjn commented Jun 15, 2022

@Mte90 we don't need this in db_restore too do we?

@Mte90
Copy link
Member Author

Mte90 commented Jun 15, 2022

I checked when I did the PR and I didn't see the error with that script

@tomjn tomjn deleted the Mte90/unbound branch June 15, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjn tomjn tomjn approved these changes

Assignees
No one assigned
Labels
provisioner:core type:bug
Projects
None yet
Milestone
3.10
Development

Successfully merging this pull request may close these issues.
2 participants
@Mte90 @tomjn