Switch to the Node.js 6.x LTS release #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On October 18th, with the release of Node.js 6.9.0, the 6.x branch was moved to LTS status. Seems like now is a good time to update our default version.
|
Sounds reasonable to me. |
|
Thanks for the PR @thebrandonallen. Pinging @ntwb as my goto source as to whether this could break the WP dev build in any way? |
ntwb
approved these changes
Oct 30, 2016
There was a problem hiding this comment.
Sounds good to me 👍
Previously the decision was made to use the latest LTS and use NVM to switch versions if needed.
Switching to the latest LTS indeed seems in order here, users can use NVM to switch back to 4.x (or 5.x, or 7.x) as needed.
Edit: I see no reason this should break the WP dev build, I've been using NodeJS 6.x for quite some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On October 18th, with the release of Node.js 6.9.0, the 6.x branch was moved to LTS status. Seems like now is a good time to update our default version.