Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R package] Allow maps to start mid-sequence #48

Closed
jweile opened this issue Jun 26, 2019 · 2 comments
Closed

[R package] Allow maps to start mid-sequence #48

jweile opened this issue Jun 26, 2019 · 2 comments

Comments

@jweile
Copy link
Collaborator

jweile commented Jun 26, 2019

The x-axis always starts at 1 at the moment. Allow that to be dynamic based on potential partial input.

Smart detection: If the the wt sequence provided is longer than the range of positions covered, then assume it starts at 1 (and print a warning), otherwise, restrict to range.

@jweile
Copy link
Collaborator Author

jweile commented Jun 27, 2019

Implemented in R-package, but causing error in webapp:

When running WW-domain:

Error in if (length(wt.aa) > coverLength) { : 
  missing value where TRUE/FALSE needed
Calls: dashboard -> genophenogram
In addition: Warning message:
In max(values, na.rm = TRUE) :
  no non-missing arguments to max; returning -Inf
{
 "scoresetID": "urn:mavedb:00000002-a-2",
"uniprot": "P46937",
"pdb": "1JMQ",
"mainChain": "A",
"WT": "GACGTTCCACTGCCGGCTGGTTGGGAAATGGCTAAAACTAGTTCTGGTCAGCGTTACTTCCTGAACCACATCGACCAGACCACCACGTGGCAGGACCCGCGT",
"seqOffset": "169",
"synMed": "1",
"stopMed": "NULL",
"pngRes": "80",
"job": "ea64ee53-35b5-434f-8828-18c9804b0370" 
}

@jweile
Copy link
Collaborator Author

jweile commented Jun 27, 2019

Identified missing na.rm=TRUE as cause.

Fixed in commit 818f6b8

@jweile jweile closed this as completed Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant