Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node to 20 and swap from webpack/vue-cli to Vite. #83

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

ashsny
Copy link
Contributor

@ashsny ashsny commented Dec 7, 2023

This involved:

  • explicitly adding the implicit dependency on the uuid package,
  • resolving the conflict @urbn/vuex-helpers and vuex by removing the former, the conflict not having shown itself until the Node version upgrade,
  • moving index.html and making the necessary changes to it,
  • adding a basic vite.config.js,
  • removing babel and support for old browsers (probably not strictly necessary),
  • removing core-js and using native js Array.reverse instead,
  • upgrade eslint and eslint-plugin-vue versions (unclear if necessary),
  • adding @vitejs/plugin-basic-ssl to generate a self-signed SSL cert,
  • adding Node polyfills to support use of Buffer via csv-parse (though see Mostly extraneous Node polyfills #82),
  • swap base64url for universal-base64url in service of eventually removing the above,
  • remove vestigial d3_rebind code that did not co-operate with Vite/Rollup,
  • changing imports in FlexDataTable.vue following https://github.com/bbi-lab/bbi-lims-ui/commit/205a5dc356fd475c9b52071e2e4a9ad77ace9e21 to support Rollup, and
  • package.json scripts and README.md updates for new dev workflows.

@ashsny ashsny requested a review from jstone-dev December 7, 2023 21:38
Copy link
Collaborator

@jstone-dev jstone-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these changes look exactly right. Soon (if you want) we should be able to import components like FlexDataTable from a separate npm package, which is present here in an old version; sorry you had to do some extra work to get it working with Node 20 and Vite, but the changes look good.

@ashsny ashsny merged commit db0ddea into release-2023.5.0 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants