Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProgressSpinner to search page and hide table contents while xhr is loading. #68

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ashsny
Copy link
Contributor

@ashsny ashsny commented Nov 14, 2023

Before this PR, the previous results are shown while a new search is loading. This also has the (intended) effect of hiding those results when a new search is initiated.

Demo: https://recordit.co/9vjBQGUAAu

Fixes #67.

@jstone-dev
Copy link
Collaborator

Looks good to me!

@ashsny ashsny merged commit e41b212 into release-2023.4.1 Nov 15, 2023
@ashsny ashsny deleted the ashsny/search-spinner branch November 15, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants