Not showing meta-analysis experiments in creating score set dropdown menu.

[EstelleDa]

No description provided.

[bencap]

My sense with this particular issue is that we should just filter the list of experiments returned to us by the API such that they exclude meta-analysis experiments. That way we don't need to make any API changes. The filter options here are a little wonky, since they don't actually serve any purpose at the moment other than denoting whether to show all experiments or just a user's experiments.

[EstelleDa]

My sense with this particular issue is that we should just filter the list of experiments returned to us by the API such that they exclude meta-analysis experiments. That way we don't need to make any API changes. The filter options here are a little wonky, since they don't actually serve any purpose at the moment other than denoting whether to show all experiments or just a user's experiments.

I changed the back-end codes too so that front end excludes the meta-analysis experiment directly. The main filter function is in VariantEffect/mavedb-api#347.

[bencap]

I changed the back-end codes too so that front end excludes the meta-analysis experiment directly. The main filter function is in VariantEffect/mavedb-api#347.

Yeah I guess that what I'm saying is that either we should make this query field hew closely to the score set structure (passing meta_analyzes_score_set: false will include only those score sets that are not meta-analysis score sets and to get only the users' current score sets we pass user_id: <current_user_id> instead of the weird current status quo where passing some: value is what does that), or we should just leave the query JSON as something we fix later on and do the filtration on the front-end.

[EstelleDa]

@bencap Sorry, I don't get your means very well or I may misunderstand something. This request is used to up an experiment list. Why do we need to make this query field close to a score set structure for the experiment request? Do you mean I had better change the query to such as query: { user_id: <current_user_id>, meta_analysis_experiment: 'false' }?
I think doing some processing on the back end is better. One main reason is I have no idea how to filter unpublished urns for meta-analysis experiments on the front end. Or do we only allow meta-analyze the published score set? I agree the original query was weird and meaningless to me too.

[bencap]

Thanks for this Estelle, the logic here looks good! We will just need to add the same logic to the ScoreSetEditor file, since that also needs a view of the users' editable experiments. Once we add that it'll be all set. Sorry for the delay in my review.

[bencap]

We will still need this definition, since it is used for the experiment creator, editor, and viewer.

[EstelleDa]

Yes, you're correct. Thanks for reminding me!!