Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create score set in experiment view page #269

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

EstelleDa
Copy link
Member

Users can click add score set button in experiment view page. It's convenient to add a score set directly after creating an experiment.
Authentication problem will be solved with editing others' score set together.

@EstelleDa EstelleDa requested a review from bencap September 11, 2024 02:01
@EstelleDa EstelleDa self-assigned this Sep 11, 2024
@EstelleDa EstelleDa linked an issue Sep 11, 2024 that may be closed by this pull request
@bencap bencap changed the base branch from release-2024.4.0 to release-2024.4.1 September 14, 2024 16:16
@bencap bencap added the type: bug Something isn't working label Sep 16, 2024
Experiment: {{ experimentUrn }}
</label>
<div class="mavedb-help-small">
To add a score set to a different experiment, superced a score set or add a score set to meta-analysis, please navigate to "New score set".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To add a score set to a different experiment, superced a score set or add a score set to meta-analysis, please navigate to "New score set".
To add a score set to a different experiment, supercede a score set or add a score set to meta-analysis, please navigate to "New score set".

Copy link
Collaborator

@bencap bencap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Estelle, this looks really nice. Up to you if you want the experiment pre-populated in the dropdown or a separate view for the experiment like what is commented out. Either way is fine with me.

@EstelleDa
Copy link
Member Author

Thanks Estelle, this looks really nice. Up to you if you want the experiment pre-populated in the dropdown or a separate view for the experiment like what is commented out. Either way is fine with me.

Thank Ben! I prefer the separate view and pre-populated abstract in rest part. Thanks for the codes. They're very helpful!

@EstelleDa EstelleDa merged commit 9a57c92 into release-2024.4.1 Sep 25, 2024
@EstelleDa EstelleDa deleted the estelle/addScoreSetButton branch September 25, 2024 07:05
@bencap bencap mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Score Set button is not present on the Experiment Screen
2 participants