Fix current version bug #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missions to view it. The current version to other users will only be the published one.
bencap
reviewed
Dec 10, 2024
src/mavedb/routers/score_sets.py
Outdated
Comment on lines
107
to
116
| if( | ||
| item | ||
| and item.superseding_score_set | ||
| and not owner_or_contributor | ||
| and ( | ||
| urn_re.MAVEDB_OLD_TMP_URN_RE.fullmatch(item.superseding_score_set.urn) | ||
| or urn_re.MAVEDB_TMP_URN_RE.fullmatch(item.superseding_score_set.urn) | ||
| ) | ||
| ): | ||
| item.superseding_score_set = None |
There was a problem hiding this comment.
What if instead of checking like this we check the permissions of the superseding score set, something like:
Suggested change
| if( | |
| item | |
| and item.superseding_score_set | |
| and not owner_or_contributor | |
| and ( | |
| urn_re.MAVEDB_OLD_TMP_URN_RE.fullmatch(item.superseding_score_set.urn) | |
| or urn_re.MAVEDB_TMP_URN_RE.fullmatch(item.superseding_score_set.urn) | |
| ) | |
| ): | |
| item.superseding_score_set = None | |
| from mavedb.lib.permissions import Action, assert_permission, has_permission | |
| if item.superseding_score_set: | |
| superseding_score_set = db.scalars(select(ScoreSet).where(ScoreSet.urn = item.superseding_score_set).one() | |
| if not has_permission(user, item, Action.READ): | |
| item.superseding_score_set = None |
This way, we don't have to maintain any extra permission logic and can guarantee the item within the superseding score set property is only returned if the user has access to it.
There was a problem hiding this comment.
I modified it. I check item.superseding_score_set directly cause it's an object.
bencap
approved these changes
Dec 17, 2024
…score sets are unpublished yet. Haven't fixed the search score set codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only show unpublished superseding score set to the users who have permissions to view it. The current version to other users will only be the published one.
Fix #370