Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl+shift+. 插入 blockquote #144

Closed
jakekwak opened this issue Feb 14, 2020 · 6 comments
Closed

ctrl+shift+. 插入 blockquote #144

jakekwak opened this issue Feb 14, 2020 · 6 comments
Assignees
@Vanessa219
Labels
改进功能
Milestone
2.2

Comments

@jakekwak
Copy link
Contributor

ctrl+., test, enter,
ctrl+., test, enter,
ctrl+., test, enter,
enter, enter, enter

blockquote1
@Vanessa219 Vanessa219 self-assigned this Feb 19, 2020
@Vanessa219 Vanessa219 added this to the 2.2 milestone Feb 19, 2020
@Vanessa219 Vanessa219 changed the title [suggestion] blockquote ctrl+. blockquote ctrl+. should toggle Feb 19, 2020
Vanessa219 added a commit that referenced this issue Feb 19, 2020
@Vanessa219
✨ #144
a18022b
@jakekwak
Copy link
Contributor Author

@Vanessa219 Did you fix this issue? not working

@Vanessa219
Copy link
Owner

I think you need to cancel when you press ctrl + . in blockquote.

If not, pls tell me the details.

@Vanessa219 Vanessa219 reopened this Feb 20, 2020
@jakekwak
Copy link
Contributor Author

jakekwak commented Feb 20, 2020 •
edited
Loading

My idea is
ctrl+.: nested inside blockquote
cancel : backspace or ctrl+shift+.
I think this one is better UI.

@Vanessa219
Copy link
Owner

Vanessa219 commented Feb 20, 2020 •
edited by 88250
Loading

Caret in a blockquote, a toolbar will highlight it.
In the toolbar, when highlighted, click to cancel; when normal, click to add.
I think what you said is better for the user experience, but this conflicts with the above and I don't know what to do.
image

@jakekwak
Copy link
Contributor Author

How about ctrl+shift+. (ctrl+>) and ctrl+shift+,(ctrl+<)

@Vanessa219 Vanessa219 changed the title blockquote ctrl+. should toggle ctrl+shift+. 插入 blockquote Feb 20, 2020
@jakekwak
Copy link
Contributor Author

blockquote

@88250 88250 reopened this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vanessa219 Vanessa219

Labels
改进功能
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
3 participants
@88250 @Vanessa219 @jakekwak