Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templatize custom strings in strings.json across application #646

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Templatize custom strings in strings.json across application #646

merged 4 commits into from
Jun 30, 2020

Conversation

gfting
Copy link
Member

@gfting gfting commented Jun 30, 2020

No description provided.

@gfting gfting requested a review from BaibhaVatsa June 30, 2020 19:28
BaibhaVatsa
BaibhaVatsa approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@BaibhaVatsa BaibhaVatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

@gfting gfting merged commit 592ec5f into feat/plugins-final Jun 30, 2020
@gfting gfting deleted the feat/clean-unify-strings branch June 30, 2020 19:32
@github-actions github-actions bot added the approved Automatically added, do not manually add label Jun 30, 2020
gfting added a commit that referenced this pull request Jun 30, 2020
@gfting
Templatize custom strings in strings.json across application (#646) (#…
84aab77 
…647)

* Centralize custom strings in client to strings.json

* Make redirect on unsubscribe templatized

* Fix typo in Announcement

* Rename application_status.svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaibhaVatsa BaibhaVatsa BaibhaVatsa approved these changes

Assignees
No one assigned
Labels
approved Automatically added, do not manually add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfting @BaibhaVatsa